Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnvidia-container: 1.3.1 -> 1.3.3 #118341

Merged
merged 1 commit into from
Apr 2, 2021
Merged

libnvidia-container: 1.3.1 -> 1.3.3 #118341

merged 1 commit into from
Apr 2, 2021

Conversation

titanous
Copy link
Contributor

@titanous titanous commented Apr 2, 2021

Motivation for this change

Required for a systemd compatibility fix (NVIDIA/nvidia-docker#1447). I can succesfully run a container using the following config and command:

boot.kernelParams = [ "systemd.unified_cgroup_hierarchy=0" ];
virtualisation.docker.enable = true;
virtualisation.docker.enableNvidia = true;
services.xserver.videoDrivers = [ "nvidia" ];
hardware.opengl.enable = true;
hardware.opengl.driSupport32Bit = true;

docker run --rm --runtime=nvidia -e NVIDIA_VISIBLE_DEVICES=all nvidia/cuda:11.2.2-base-ubuntu20.04 nvidia-smi
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@titanous titanous requested a review from cpcloud April 2, 2021 17:07
@cpcloud
Copy link
Contributor

cpcloud commented Apr 2, 2021

Interesting, I've been using the current version (with boot.kernelParams = [ "systemd.unified_cgroup_hierarchy=0" ];) for quite a while. How does the version bump interact with the lack of cgroupv2 support?

@titanous
Copy link
Contributor Author

titanous commented Apr 2, 2021

Interesting, I've been using the current version (with boot.kernelParams = [ "systemd.unified_cgroup_hierarchy=0" ];) for quite a while. How does the version bump interact with the lack of cgroupv2 support?

This may not be required to get it to work then, though we should still bump the package. I was in a yak shave and ended up bumping this in the process.

@cpcloud
Copy link
Contributor

cpcloud commented Apr 2, 2021

Fair enough!

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 7bf7606 into NixOS:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titanous @cpcloud @SuperSandro2000